-
Notifications
You must be signed in to change notification settings - Fork 10
fix: indicate supported version for GML [DHIS2-18232] #2196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Deployed on https://pr-2196--dhis2-import-export.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; thanks 🙏. See comment re: the translation parsing.
<FileUpload | ||
helpText={i18n.t( | ||
'Supported version: GML 2.0 only.' | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a non-standard nsSeparator
as an option here, e.g.
helpText={i18n.t('Supported version: GML 2.0 only.', { nsSeparator: '>' })
?
otherwise, the i18next-scanner will not correctly scan the text for the en.pot file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with: 211a37a
|
## [101.1.30](v101.1.29...v101.1.30) (2025-09-12) ### Bug Fixes * indicate supported version for GML import [DHIS2-18232] ([#2196](#2196)) ([5fde9dc](5fde9dc))
🎉 This PR is included in version 101.1.30 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Implements: https://dhis2.atlassian.net/browse/DHIS2-18232