Skip to content

Conversation

BRaimbault
Copy link
Contributor

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Aug 22, 2025

🚀 Deployed on https://pr-2196--dhis2-import-export.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify August 22, 2025 14:41 Inactive
@BRaimbault BRaimbault changed the title fix: indicate supported version for GML [DHIS2-17061] fix: indicate supported version for GML [DHIS2-18232] Aug 22, 2025
@dhis2-bot dhis2-bot temporarily deployed to netlify August 22, 2025 14:49 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify August 22, 2025 14:52 Inactive
@BRaimbault BRaimbault requested a review from a team September 11, 2025 13:37
Copy link
Member

@tomzemp tomzemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks 🙏. See comment re: the translation parsing.

<FileUpload
helpText={i18n.t(
'Supported version: GML 2.0 only.'
)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a non-standard nsSeparator as an option here, e.g.
helpText={i18n.t('Supported version: GML 2.0 only.', { nsSeparator: '>' })?

otherwise, the i18next-scanner will not correctly scan the text for the en.pot file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with: 211a37a

Copy link

@dhis2-bot dhis2-bot temporarily deployed to netlify September 12, 2025 07:35 Inactive
@BRaimbault BRaimbault merged commit 5fde9dc into master Sep 12, 2025
9 checks passed
@BRaimbault BRaimbault deleted the fix/DHIS2-17061 branch September 12, 2025 07:58
dhis2-bot added a commit that referenced this pull request Sep 12, 2025
## [101.1.30](v101.1.29...v101.1.30) (2025-09-12)

### Bug Fixes

* indicate supported version for GML import [DHIS2-18232] ([#2196](#2196)) ([5fde9dc](5fde9dc))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.1.30 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants